Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @sabercodic)

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 54 at r1 (raw file):

        }
    }
    LaunchedEffect(isCollapsable) {

I would use Unit instead.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/Scaffolding.kt line 78 at r1 (raw file):

        }
    }
    LaunchedEffect(isCollapsable) {

I would use Unit instead.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 75 at r1 (raw file):

) {
    val context = LocalContext.current
    val isCollapsable by remember { mutableStateOf(false) }

This could be removed.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 80 at r1 (raw file):

    LaunchedEffect(Unit) { uiCloseAction.collect { onBackClick() } }
    LaunchedEffect(isCollapsable) {

Could be replaced with Unit.

Reviewable status: 1 of 4 files reviewed, 4 unresolved discussions (waiting on @Pururun)

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 54 at r1 (raw file):

Done.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/Scaffolding.kt line 78 at r1 (raw file):

Done.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 75 at r1 (raw file):

Done.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 80 at r1 (raw file):

Done.

Reviewable status: 1 of 4 files reviewed, 4 unresolved discussions (waiting on @Pururun)

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: 2 of 4 files reviewed, 6 unresolved discussions (waiting on @Pururun and @sabercodic)

-- commits line 2 at r2:
Clarify this commit message

Code quote:

Change paint statusbar time

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 55 at r2 (raw file):

    }
    LaunchedEffect(Unit) {
        delay(context.resources.getInteger(R.integer.transition_animation_duration).toLong())

I believe we should use a constant instead since it's easier to use in compose and we're moving away from resources for most other similar things (font styling, colors etc).

Code quote:

R.integer.transition_animation_duration

Reviewable status: 2 of 4 files reviewed, 6 unresolved discussions (waiting on @albin-mullvad and @Pururun)

-- commits line 2 at r2:

Done.

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 55 at r2 (raw file):

Done, I

Reviewed 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 55 at r3 (raw file):

    }
    LaunchedEffect(Unit) {
        delay(SCREEN_ENTER_TRANSITION)

Is there no way of triggering a callback when the animation/transition is complete rather using a delay? It seems like that would make more sense, especially for cases such as disabled animations (in system settings).

If having a proper callback is simplified by using Compose Navigation and the animation/transition support added in 2.7.0 it might be worth skipping this for now.

Code quote:

delay

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Pururun)

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/CollapsingToolbarScaffold.kt line 55 at r3 (raw file):

Done.

Reviewed 16 of 16 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Reviewed 13 of 16 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved